Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fix and test for foldBlocks, backported to 1.35 release branch #4680

Closed

Conversation

eyeinsky
Copy link
Contributor

New version of the older PR, now based off of a branch in this repository.

eyeinsky added a commit that referenced this pull request Nov 30, 2022


- Add hashes of genesis.json to node configuration
- Add test for running foldBlocks on testnet
@eyeinsky eyeinsky force-pushed the ml/foldblocks-test--backport-to-1.35.4-new branch from 8e2fa02 to 5016aa3 Compare November 30, 2022 13:38
Copy link
Contributor

@JaredCorduan JaredCorduan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for adding tests!

eyeinsky added a commit that referenced this pull request Dec 14, 2022


- Add hashes of genesis.json to node configuration
- Add test for running foldBlocks on testnet
@eyeinsky eyeinsky force-pushed the ml/foldblocks-test--backport-to-1.35.4-new branch from 5016aa3 to 9558f37 Compare December 14, 2022 10:50


- Add hashes of genesis.json to node configuration
- Add test for running foldBlocks on testnet
@eyeinsky eyeinsky force-pushed the ml/foldblocks-test--backport-to-1.35.4-new branch from 9558f37 to 13b811e Compare December 14, 2022 11:16
@eyeinsky
Copy link
Contributor Author

We've disabled the test that depended on this fix and will enable it again when when we depend on a new release of cardano-node.

@eyeinsky eyeinsky closed this Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants