-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fix and test for foldBlocks
, backported to 1.35 release branch
#4680
Closed
eyeinsky
wants to merge
11
commits into
release/1.35
from
ml/foldblocks-test--backport-to-1.35.4-new
Closed
Add fix and test for foldBlocks
, backported to 1.35 release branch
#4680
eyeinsky
wants to merge
11
commits into
release/1.35
from
ml/foldblocks-test--backport-to-1.35.4-new
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eyeinsky
requested review from
dcoutts,
Jimbo4350,
erikd,
newhoggy and
JaredCorduan
as code owners
November 29, 2022 18:39
eyeinsky
force-pushed
the
ml/foldblocks-test--backport-to-1.35.4-new
branch
from
November 30, 2022 13:38
8e2fa02
to
5016aa3
Compare
9 tasks
JaredCorduan
approved these changes
Dec 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for adding tests!
Jimbo4350
approved these changes
Dec 6, 2022
eyeinsky
force-pushed
the
ml/foldblocks-test--backport-to-1.35.4-new
branch
from
December 14, 2022 10:50
5016aa3
to
9558f37
Compare
eyeinsky
force-pushed
the
ml/foldblocks-test--backport-to-1.35.4-new
branch
from
December 14, 2022 11:16
9558f37
to
13b811e
Compare
eyeinsky
requested review from
deepfire,
jutaro,
MarcFontaine,
mgmeier and
cleverca22
as code owners
January 3, 2023 16:24
We've disabled the test that depended on this fix and will enable it again when when we depend on a new release of cardano-node. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New version of the older PR, now based off of a branch in this repository.